From: Patrick McHardy <kaber@trash•net>
To: "Denis V. Lunev" <den@openvz•org>
Cc: davem@davemloft•net, johannes@sipsolutions•net, tgraf@suug•ch,
pablo@netfilter•org, netdev@vger•kernel.org
Subject: Re: [PATCH] make netlink processing routines semi-synchronious (inspired by rtnl)
Date: Mon, 01 Oct 2007 15:10:12 +0200 [thread overview]
Message-ID: <4700F1B4.4090603@trash.net> (raw)
In-Reply-To: <20071001124042.GA8878@iris.sw.ru>
Denis V. Lunev wrote:
> The code in netfilter/nfnetlink.c and in ./net/netlink/genetlink.c looks
> like outdated copy/paste from rtnetlink.c. Push them into sync with the
> original.
>
> int nfnetlink_subsys_register(const struct nfnetlink_subsystem *n)
> @@ -149,7 +137,7 @@ static int nfnetlink_rcv_msg(struct sk_b
> #ifdef CONFIG_KMOD
> /* don't call nfnl_unlock, since it would reenter
> * with further packet processing */
> - __nfnl_unlock();
> + nfnl_unlock();
That comment should be updated/deleted. Rest looks good to me.
prev parent reply other threads:[~2007-10-01 13:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-01 12:40 [PATCH] make netlink processing routines semi-synchronious (inspired by rtnl) Denis V. Lunev
2007-10-01 13:10 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4700F1B4.4090603@trash.net \
--to=kaber@trash$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=den@openvz$(echo .)org \
--cc=johannes@sipsolutions$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pablo@netfilter$(echo .)org \
--cc=tgraf@suug$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox