Subject: Re: [PATCH 05/10] Add divisor.

From: Patrick McHardy <[email-masked]>
Date: Mon, 01 Oct 2007 15:38:07 +0200

Corey Hickey wrote:
> Make hash divisor user-configurable.
> 

> @@ -120,7 +121,7 @@ static __inline__ unsigned sfq_fold_hash(struct sfq_sched_data *q, u32 h, u32 h1
>  	/* Have we any rotation primitives? If not, WHY? */
>  	h ^= (h1<<pert) ^ (h1>>(0x1F - pert));
>  	h ^= h>>10;
> -	return h & 0x3FF;
> +	return h & (q->hash_divisor-1);

This assumes that hash_divisor is a power of two, but this is
not enforced anywhere.