Subject: Re: [PATCH 06/10] Make qdisc changeable.

From: Corey Hickey <[email-masked]>
Date: Mon, 01 Oct 2007 13:47:10 -0700

Patrick McHardy wrote:
> Corey Hickey wrote:
>> Re-implement sfq_change() and enable Qdisc_opts.change so "tc qdisc
>> change" will work.
>>
> 
>> +static int sfq_change(struct Qdisc *sch, struct rtattr *opt)
>> +{
>> +	...
>> +
>> +	/* finish up */
>> +	if (q->perturb_period) {
>> +		q->perturb_timer.expires = jiffies + q->perturb_period;
>> +		add_timer(&q->perturb_timer);
>> +	} else {
>> +		q->perturbation = 0;
> 
> 
> Seems counter-productive to explicitly set it to zero since
> it was still used during tranfering the packets with the
> old value. So I'd suggest to remove this or alternatively
> set it to the final value *before* transfering the packets.

I suppose so; you're right. I'll adapt that part to fit before 
transferring the packets.

-Corey