From: Patrick McHardy <kaber@trash•net>
To: Corey Hickey <bugfood-ml@fatooh•org>
Cc: Linux Netdev List <netdev@vger•kernel.org>
Subject: Re: [PATCH 01/10] Preparatory refactoring part 1.
Date: Tue, 02 Oct 2007 05:17:06 +0200 [thread overview]
Message-ID: <4701B832.4090405@trash.net> (raw)
In-Reply-To: <47015CB4.7000102@fatooh.org>
Corey Hickey wrote:
> Patrick McHardy wrote:
>
>>> - sch->qstats.drops++;
>>
>> A line in the changelog explaining that this was increased twice
>> would have been nice.
>
>
> Certainly; I think I didn't realize, when you originally pointed out the
> duplicate incrementing, that it was a bug in the original version and
> not in my patch. Otherwise, I would have sent it as a separate patch.
I didn't remember that :)
> If a note in this patch will suffice, though, I'll definitely do so.
Sure, a note in the changelog will be fine.
>>> +static struct
>>> +sk_buff *sfq_q_dequeue(struct sfq_sched_data *q)
>>
>>
>>
>> What is this function needed for?
>
>
> It gets used in sfq_change for moving packets from the old queue into
> the new one. In this case, we don't want to modify sch->q.qlen or
> sch->qstats.backlog, since those don't actually change.
>
> while ((skb = sfq_q_dequeue(q)) != NULL)
> sfq_q_enqueue(skb, &tmp, SFQ_TAIL);
I missed that, thanks for the explanation.
next prev parent reply other threads:[~2007-10-02 3:17 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-28 22:52 SFQ: backport some features from ESFQ (try 4) Corey Hickey
2007-09-28 22:52 ` [PATCH 01/10] Preparatory refactoring part 1 Corey Hickey
2007-10-01 13:25 ` Patrick McHardy
2007-10-01 20:46 ` Corey Hickey
2007-10-02 3:17 ` Patrick McHardy [this message]
2007-09-28 22:52 ` [PATCH 02/10] Preparatory refactoring part 2 Corey Hickey
2007-10-01 13:33 ` Patrick McHardy
2007-10-01 20:46 ` Corey Hickey
2007-10-02 3:19 ` Patrick McHardy
2007-09-28 22:52 ` [PATCH 03/10] Move two functions Corey Hickey
2007-10-01 13:27 ` Patrick McHardy
2007-10-01 20:46 ` Corey Hickey
2007-09-28 22:52 ` [PATCH 04/10] Make "depth" (number of queues) user-configurable: Corey Hickey
2007-09-28 22:52 ` [PATCH 05/10] Add divisor Corey Hickey
2007-10-01 13:38 ` Patrick McHardy
2007-10-01 20:47 ` Corey Hickey
2007-09-28 22:52 ` [PATCH 06/10] Make qdisc changeable Corey Hickey
2007-10-01 13:43 ` Patrick McHardy
2007-10-01 20:47 ` Corey Hickey
2007-09-28 22:52 ` [PATCH 07/10] Remove comments about hardcoded values Corey Hickey
2007-09-28 22:52 ` [PATCH 08/10] Multiply perturb_period by HZ when used rather than when assigned Corey Hickey
2007-09-28 22:52 ` [PATCH 09/10] Change perturb_period to unsigned Corey Hickey
2007-10-01 13:45 ` Patrick McHardy
2007-10-01 20:47 ` Corey Hickey
2007-09-28 22:52 ` [PATCH 10/10] Use nested compat attributes to pass parameters Corey Hickey
2007-10-01 13:54 ` Patrick McHardy
2007-10-01 20:47 ` Corey Hickey
2007-10-02 3:21 ` Patrick McHardy
2007-09-28 22:54 ` sfq Corey Hickey
2007-09-28 22:57 ` sfq (iproute2 patches) Corey Hickey
2007-09-28 22:54 ` [PATCH 1/3] SFQ: Support changing depth and divisor Corey Hickey
2007-09-28 22:54 ` [PATCH 2/3] Change perturb_period to unsigned Corey Hickey
2007-09-28 22:54 ` [PATCH 3/3] Use nested compat attributes for passing parameters to the kernel Corey Hickey
2007-09-29 15:38 ` SFQ: backport some features from ESFQ (try 4) Patrick McHardy
2007-09-29 17:36 ` Corey Hickey
-- strict thread matches above, loose matches on Subject: below --
2007-08-25 22:26 [PATCH 00/10] SFQ: backport some features from ESFQ (try 3) Corey Hickey
2007-08-25 22:26 ` [PATCH 01/10] Preparatory refactoring part 1 Corey Hickey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4701B832.4090405@trash.net \
--to=kaber@trash$(echo .)net \
--cc=bugfood-ml@fatooh$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox