Subject: Re: [PATCH] sky2: jumbo frame regression fix

From: Jeff Garzik <[email-masked]>
Date: Wed, 03 Oct 2007 00:58:46 -0400

Stephen Hemminger wrote:
> On Tue, 02 Oct 2007 21:07:22 -0400
> Jeff Garzik <[email-masked]> wrote:
> 
>> Stephen Hemminger wrote:
>>> Remove unneeded check that caused problems with jumbo frame sizes.
>>> The check was recently added and is wrong.
>>> When using jumbo frames the sky2 driver does fragmentation, so
>>> rx_data_size is less than mtu.
>>>
>>> Signed-off-by: Stephen Hemminger <[email-masked]>
>>>
>>> --- a/drivers/net/sky2.c	2007-10-02 17:56:31.000000000 -0700
>>> +++ b/drivers/net/sky2.c	2007-10-02 17:58:56.000000000 -0700
>>> @@ -2163,9 +2163,6 @@ static struct sk_buff *sky2_receive(stru
>>>  	sky2->rx_next = (sky2->rx_next + 1) % sky2->rx_pending;
>>>  	prefetch(sky2->rx_ring + sky2->rx_next);
>>>  
>>> -	if (length < ETH_ZLEN || length > sky2->rx_data_size)
>>> -		goto len_error;
>>> -
>> 2.6.23?  2.6.24?  enquiring minds want to know...
> 
> 2.6.23, since it is a regression

You can have regressions in behavior in net-2.6.24.git, too.  _Please_ 
be specific about where you want your patches to go.  Thanks.

	Jeff