From: Cedric Le Goater <legoater@free•fr>
To: "Ilpo Järvinen" <ilpo.jarvinen@helsinki•fi>
Cc: David Miller <davem@davemloft•net>, Netdev <netdev@vger•kernel.org>
Subject: Re: [PATCH net-2.6.24 0/3]: More TCP fixes
Date: Wed, 03 Oct 2007 16:05:47 +0200 [thread overview]
Message-ID: <4703A1BB.1040006@free.fr> (raw)
In-Reply-To: <Pine.LNX.4.64.0710031554380.27745@kivilampi-30.cs.helsinki.fi>
Ilpo Järvinen wrote:
> On Wed, 3 Oct 2007, Cedric Le Goater wrote:
>
>> Ilpo Järvinen wrote:
>>> On Wed, 3 Oct 2007, Cedric Le Goater wrote:
>>>
>>>> I'm dropping the previous patches you sent me and switching to this patchset.
>>>> right ?
>>> Yes you can do that... However, there are two ways forward:
>>>
>>> 1) Drop and test with this patchset long enough to verify it's gone...
>>> 2) No dropping and get the more exact trace by reproducing, which can
>>> point out to tcp_retrans_try_collapse confirming the source of the
>>> bug or revealing yet another bug...
>>>
>>> The first one has one drawback, it cannot prove the fix very well since
>>> the bug could just not occur by chance... Path 2 would clearly show the
>>> place from where the problem originates because we will know that it got
>>> triggered! I personally would prefer path 2 but whether you want to go for
>>> that depends on the time you want to invest in it...
>>>
>>> ...I rediffed the tcp_verify_fackets patch too (below) just in case it
>>> would be something else in you case and you choose path 1 (put it on top
>>> of this patchset, applies with some offsets). In case the problem is gone,
>>> it shouldn't trigger and if it does, we'll have another bug caught.
>> I have a spare node so I'm starting 2) with the 3 patches you sent and that
>> last one which applied fine.
>
> Ah, that's path 1) then... Since you seem to have enough time, I would say
> that the path 1 is good as well and bugs unrelated to the fix will show up
> there too...
arg. yes. sorry for the confusion.
> I should have stated it explicitly that with path 2 those 3 patches should
> not be applied because the aim is not a fix but reproducal. Path 2 was
> intentionally left without the potentional fix as then nice backtrace
> informs when we can stop trying (which would hopefully occurred
> pretty soon) :-). But lets discard that path 2...
I have 2 spare nodes so i'll run both. 1) is on already without any issues
i'm just compiling 2)
I usually work on -mm, so what would be interesting for me is to have what you
need in net-2.6.24 which is getting pulled in -mm by andrew. then, if you need
an extra patch for verbosity, that's fine, i'll include it in my usual patchset.
Cheers,
C.
>> all of them on a fresh git pull of net-2.6.24
>
> That's fine, they're pretty well in sync (mm and net-2.6.24, and
> soon 2.6.24-rcs too).
>
next prev parent reply other threads:[~2007-10-03 14:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-03 11:00 [PATCH net-2.6.24 0/3]: More TCP fixes Ilpo Järvinen
2007-10-03 11:00 ` [PATCH 1/3] [TCP]: Fix two off-by-one errors in fackets_out adjusting logic Ilpo Järvinen
2007-10-03 11:00 ` [PATCH 2/3] [TCP]: Comment fastpath_cnt_hint off-by-one trap Ilpo Järvinen
2007-10-03 11:00 ` [PATCH 3/3] [TCP]: "Annotate" another fackets_out state reset Ilpo Järvinen
2007-10-08 6:38 ` David Miller
2007-10-08 6:37 ` [PATCH 2/3] [TCP]: Comment fastpath_cnt_hint off-by-one trap David Miller
2007-10-08 6:36 ` [PATCH 1/3] [TCP]: Fix two off-by-one errors in fackets_out adjusting logic David Miller
2007-10-03 11:58 ` [PATCH net-2.6.24 0/3]: More TCP fixes Cedric Le Goater
2007-10-03 12:34 ` Ilpo Järvinen
2007-10-03 12:48 ` Cedric Le Goater
2007-10-03 13:19 ` Ilpo Järvinen
2007-10-03 14:05 ` Cedric Le Goater [this message]
2007-10-03 14:22 ` Ilpo Järvinen
2007-10-03 14:58 ` Cedric Le Goater
2007-10-03 14:59 ` Cedric Le Goater
2007-10-03 15:12 ` Cedric Le Goater
2007-10-04 10:13 ` Ilpo Järvinen
2007-10-04 14:53 ` Cedric Le Goater
2007-10-04 20:20 ` [PATCH net-2.6.24] [TCP]: Fix fastpath_cnt_hint when GSO skb is partially ACKed Ilpo Järvinen
2007-10-08 6:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4703A1BB.1040006@free.fr \
--to=legoater@free$(echo .)fr \
--cc=davem@davemloft$(echo .)net \
--cc=ilpo.jarvinen@helsinki$(echo .)fi \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox