Subject: Re: [PATCH net-2.6.24] s2io: sparse warnings fix

From: Jeff Garzik <[email-masked]>
Date: Fri, 05 Oct 2007 13:51:51 -0400

Stephen Hemminger wrote:
> Fix warnings from sparse checker about shadowed definition and improperly
> formatted ethtool_strings.
> 
> I chose to change module parameter rather than uglify the code by changing
> the variable name.

Changing the name of existing module parameters can potentially 
introduce breakage in the field.

Additionally, we have module_param_named() to account for this sort of 
thing, where the module parameter name differs from the internal 
variable name.

The rest looks OK.

Please resend, potentially moving the module parameter change(s) into a 
separate patch.