From: Jeff Garzik <jgarzik@pobox•com>
To: Jay Vosburgh <fubar@us•ibm.com>
Cc: Moni Shoua <monisonlists@gmail•com>,
Roland Dreier <rdreier@cisco•com>,
netdev <netdev@vger•kernel.org>
Subject: Re: [PATCH V6 1/9] IB/ipoib: Bound the net device to the ipoib_neigh structue
Date: Fri, 05 Oct 2007 13:57:17 -0400 [thread overview]
Message-ID: <47067AFD.40802@pobox.com> (raw)
In-Reply-To: <16822.1191538040@death>
Jay Vosburgh wrote:
> IPoIB uses a two layer neighboring scheme, such that for each struct neighbour
> whose device is an ipoib one, there is a struct ipoib_neigh buddy which is
> created on demand at the tx flow by an ipoib_neigh_alloc(skb->dst->neighbour)
> call.
>
> When using the bonding driver, neighbours are created by the net stack on behalf
> of the bonding (master) device. On the tx flow the bonding code gets an skb such
> that skb->dev points to the master device, it changes this skb to point on the
> slave device and calls the slave hard_start_xmit function.
>
> Under this scheme, ipoib_neigh_destructor assumption that for each struct
> neighbour it gets, n->dev is an ipoib device and hence netdev_priv(n->dev)
> can be casted to struct ipoib_dev_priv is buggy.
>
> To fix it, this patch adds a dev field to struct ipoib_neigh which is used
> instead of the struct neighbour dev one, when n->dev->flags has the
> IFF_MASTER bit set.
>
> Signed-off-by: Moni Shoua <monis at voltaire.com>
> Signed-off-by: Or Gerlitz <ogerlitz at voltaire.com>
> Acked-by: Roland Dreier <rdreier@cisco•com>
ACK, but patches do not apply to jgarzik/netdev-2.6.git#upstream nor
davem/net-2.6.24.git, so I was forced to drop the patch series :(
parent reply other threads:[~2007-10-05 17:57 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <16822.1191538040@death>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47067AFD.40802@pobox.com \
--to=jgarzik@pobox$(echo .)com \
--cc=fubar@us$(echo .)ibm.com \
--cc=monisonlists@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rdreier@cisco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox