Subject: Re: [PATCH]: Third (final?) release of Sun Neptune driver

From: Oliver Hartkopp <[email-masked]>
Date: Mon, 08 Oct 2007 18:04:15 +0200

David Miller wrote:
>  	if (err < 0)
> -		return err;
> +		goto out_err;
>  
>  	if (err != (PHYXS_XGXS_LANE_STAT_ALINGED |
>  		    PHYXS_XGXS_LANE_STAT_MAGIC |
> @@ -1133,6 +1133,10 @@ out:
>  
>  	*link_up_p = link_up;
>  	return 0;
> +
> +out_err:
> +	spin_unlock_irqrestore(&np->lock, flags);
> +	return err;
>  }
>  
>  static int link_status_1g(struct niu *np, int *link_up_p)
>   

Should *link_up_p be set to any valid value in the out_err case in 
link_status_10g()?

Oliver