From: Daniel Lezcano <dlezcano@fr•ibm.com>
To: Pavel Emelyanov <xemul@openvz•org>
Cc: David Miller <davem@davemloft•net>,
Linux Netdev List <netdev@vger•kernel.org>,
devel@openvz•org, "Eric W. Biederman" <ebiederm@xmission•com>
Subject: Re: [PATCH][NETNS] Make ifindex generation per-namespace
Date: Tue, 09 Oct 2007 16:48:16 +0200 [thread overview]
Message-ID: <470B94B0.6060504@fr.ibm.com> (raw)
In-Reply-To: <470B71CD.3000706@openvz.org>
Pavel Emelyanov wrote:
> Currently indexes for netdevices come sequentially one by
> one, and the same stays true even for devices that are
> created for namespaces.
>
> Side effects of this are:
> * lo device has not 1 index in a namespace. This may break
> some userspace that relies on it (and AFAIR something
> really broke in OpenVZ VEs without this);
> * after some time namespaces will have devices with indexes
> like 1000000 os similar. This might be confusing for a
> human (tools will not mind).
>
> So move the (currently "global" and static) ifindex variable
> on the struct net, making the indexes allocation look more
> like on a standalone machine.
>
> Moreover - when we have indexes intersect between namespaces,
> we may catch more BUGs in the future related to "wrong device
> was found for a given index".
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz•org>
Applied and tested against netns49. Works fine.
Acked-by: Daniel Lezcano <dlezcano@fr•ibm.com>
next prev parent reply other threads:[~2007-10-09 14:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-09 12:19 [PATCH][NETNS] Make ifindex generation per-namespace Pavel Emelyanov
2007-10-09 14:48 ` Daniel Lezcano [this message]
2007-10-09 16:18 ` David Stevens
2007-10-09 17:43 ` Eric W. Biederman
2007-10-09 20:11 ` David Miller
2007-10-09 21:00 ` Eric W. Biederman
2007-10-09 21:17 ` David Miller
2007-10-09 20:12 ` David Miller
2007-10-09 17:41 ` Eric W. Biederman
2007-10-10 8:55 ` Pavel Emelyanov
2007-10-10 18:15 ` Eric W. Biederman
2007-10-10 18:34 ` Johannes Berg
2007-10-10 19:51 ` Eric W. Biederman
2007-10-11 9:32 ` Johannes Berg
2007-10-11 17:22 ` Eric W. Biederman
2007-10-09 20:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=470B94B0.6060504@fr.ibm.com \
--to=dlezcano@fr$(echo .)ibm.com \
--cc=davem@davemloft$(echo .)net \
--cc=devel@openvz$(echo .)org \
--cc=ebiederm@xmission$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xemul@openvz$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox