Subject: Re: [RFC/PATCH 4/4] UDP memory usage accounting (take 4): memory limitation

From: Satoshi OSHIMA <[email-masked]>
Date: Fri, 12 Oct 2007 20:58:06 +0900

Hi Stephen,

> On Thu, 11 Oct 2007 21:51:14 +0900
> Satoshi OSHIMA <[email-masked]> wrote:
> 
>> Hi Stephen,
>>
>> Thank you for your comment.
>>
>>>>  	{
>>>> +		.ctl_name	= NET_UDP_MEM,
>>>> +		.procname	= "udp_mem",
>>>> +		.data		= &sysctl_udp_mem,
>>>> +		.maxlen		= sizeof(sysctl_udp_mem),
>>>> +		.mode		= 0644,
>>>> +		.proc_handler	= &proc_dointvec
>>>> +	},
>>>> +	{
>>>>  		.ctl_name	= NET_TCP_APP_WIN,
>>>>  		.procname	= "tcp_app_win",
>>>>  		.data		= &sysctl_tcp_app_win,
>>> if you use &proc_dointvec_minmax, then you could inforce min/max
>>> values for udp_mem for the sysctl
> 
> One other comment. Sysctl value indexes are deprecated at this point
> so all new values should use CTL_UNNUMBERED.  Therefore unless NET_UDP_MEM
> already exists, please don't add it.

Thank you for letting me know. I will fix it.

Satoshi Oshima