Subject: Re: [PATCH 2/3] [NET_CLS_ACT] Use skb_act_clone

From: Patrick McHardy <[email-masked]>
Date: Tue, 16 Oct 2007 14:53:25 +0200

jamal wrote:

[Can't quote for some reason ..]

I don't think this change is safe since we might loose the
redirect counter and have endless redirect loops. ipip for
example calls skb_realloc_headroom, which clones the skb
when delta > 0, so it seems we really need to copy tc_verd
in skb_clone(). Generally the assumption that drivers don't
clone packets doesn't seem safe.