Subject: Re: [PATCH 0/2] Interface groups, round two

From: Laszlo Attila Toth <[email-masked]>
Date: Thu, 18 Oct 2007 13:34:27 +0200

Patrick McHardy írta:
> Laszlo Attila Toth wrote:
>> Hello,
>>
>> Here is the new version of ifgroup patches.
>>
>> The interface group value is u_int32_t in net_device which should be 
>> enough.
>> Previously it was an int.
>>
>> Usage:
>>    ip link set eth0 group 4
>> but currently it cannot be unset, only changed to another value.
> 
> 
> The only reason why it can't be set to zero again seems to
> be this part from the iproute patch:
> 
> +            if (rtnl_ifgroup_a2n(&group, *argv) || group == 0)
> 
> Why don't you allow a value of zero?
> 

It has historical reason. The original version which didn't use netlink 
(at kernel 2.6.17) used zero to indicate that group was not set. You 
wrote previously that this part is useless for new kernels. I'll fix 
this (with type of "group" variable to unsigned int32 to be consistent 
with the kernel part).

-- 
Attila