Subject: Re: Endianness problem with u32 classifier hash masks

From: Jarek Poplawski <[email-masked]>
Date: Sun, 04 Nov 2007 01:30:03 +0100

Jarek Poplawski wrote, On 11/04/2007 12:58 AM:

> Jarek Poplawski wrote, On 11/04/2007 12:39 AM:
> ...
> 
> OOPS!!! Went too early! I've tried to save not send. Probably my
> bad pronunciation...
> 
> But, it seems this could be something like this (instead of Radu's
> change in u32_classify()). The change of hmask is needed.

OK, not exactly... hmask should be ntohl'ed only for fshift:

u32 mask = ntohl(s->hmask);
...

Other changes seem to be not needed.

> 
> But it needs more checking...

Jarek P.