Subject: Re: [patch, v2.6.26-rc5] net/irda build fix: mcs7780

From: <[email-masked]>
Date: Mon, 09 Jun 2008 11:26:37 +0200

On Mon, 9 Jun 2008 10:22:57 +0200, Ingo Molnar <[email-masked]> wrote:

> -tip testing found the following build error:

>   drivers/built-in.o: In function `mcs_receive_irq':

>   mcs7780.c:(.text+0x4e429): undefined reference to `crc32_le'

>   drivers/built-in.o: In function `mcs_hard_xmit':

>   mcs7780.c:(.text+0x4e9af): undefined reference to `crc32_le'

> with:

>   http://redhat.com/~mingo/misc/config-Sun_Jun__8_22_56_14_CEST_2008.bad

> the reason is a missing enablement of the CRC32 library in the Kconfig.

> Signed-off-by: Ingo Molnar <[email-masked]>

Many thanks Ingo.

Dave, I can take it with my next IrDA patch set. But since it's a build

failure, you may want to take it immediatly, it's up to you.

In the latter case:

Signed-off-by: Samuel Ortiz <[email-masked]>

> ---

>  drivers/net/irda/Kconfig |    1 +

>  1 file changed, 1 insertion(+)

> Index: linux/drivers/net/irda/Kconfig

> ===================================================================

> --- linux.orig/drivers/net/irda/Kconfig

> +++ linux/drivers/net/irda/Kconfig

> @@ -329,6 +329,7 @@ config PXA_FICP

>  config MCS_FIR

>  	tristate "MosChip MCS7780 IrDA-USB dongle"

>  	depends on IRDA && USB && EXPERIMENTAL

> +	select CRC32

>  	help

>  	  Say Y or M here if you want to build support for the MosChip

>  	  MCS7780 IrDA-USB bridge device driver.

> --

> To unsubscribe from this list: send the line "unsubscribe netdev" in

> the body of a message to [email-masked]

> More majordomo info at  http://vger.kernel.org/majordomo-info.html