Subject: Re: [PATCH 2.6.24 1/1]S2io: Fixed memory leak by freeing MSI-X local entry memories when vector allocation fails

From: Jeff Garzik <[email-masked]>
Date: Tue, 06 Nov 2007 12:46:26 -0500

Sreenivasa Honnur wrote:
> - Fixed memory leak by freeing MSI-X local entry memories when vector allocation
> fails in s2io_add_isr.
> - Added two utility functions remove_msix_isr and remove_inta_isr to eliminate
> code duplication.
> - Implemented following review comments from Jeff
> 	- Removed redundant stats->mem_freed and synchronize_irq call
> 	- do_rem_msix_isr is renamed as remove_msix_isr
> 	- do_rem_inta_isr is renamed as remove_inta_isr
> 
> Signed-off-by: Sreenivasa Honnur <[email-masked]>
> Signed-off-by: Ramkrishna Vepa <[email-masked]>

this patch should go into 2.6.24-rc, but it doesn't apply to upstream.

This may be because it requires "S2io: Support for 
add/delete/store/restore ethernet addresses", I am guessing?

We want to reverse the order of those two patches, because "S2io: 
Support for add/delete/store/restore ethernet addresses" is more 
appropriate for non-bug-fix 2.6.24 rather than current bugfix-only 
2.6.24-rc.

	Jeff