Subject: Re: [Resend][PATCH 01/05] ipv6: RFC4214 Support (4)

From: Vlad Yasevich <[email-masked]>
Date: Mon, 12 Nov 2007 17:22:48 -0500

Hi Fred

Templin, Fred L wrote:
> Vlad,
> 
> Yes, I was breaking into multiples to ease review only.
> The "[PATCH 01/04] ... (5)" thread includes the complete
> reviewable and patchable final text in 4 files. In my
> next message, I will put the entire patchfile as inline
> text. (The "[PATCH 01/01] ... (5)" for 'iproute2' is
> already complete.)
> 

Ok, thanks for the explanation.  One questions is though why
do we need all the #if defines() throughout the file?

Most distros end up enabled almost everything anyway.  Looking
at the code, there is really nothing that needs a conditional.
Removing the conditionals would make things cleaner.

Just some of my thoughts.

Thanks
-vlad