From: Eric Dumazet <dada1@cosmosbay•com>
To: "David S. Miller" <davem@davemloft•net>
Cc: netdev@vger•kernel.org, Patrick McHardy <kaber@trash•net>
Subject: [NET] netfilter : xt_time should not assume CONFIG_KTIME_SCALAR
Date: Tue, 13 Nov 2007 12:30:37 +0100 [thread overview]
Message-ID: <47398ADD.2030509@cosmosbay.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 143 bytes --]
It is not correct to assume one can get nsec from a ktime directly by
using .tv64 field.
Signed-off-by: Eric Dumazet <dada1@cosmosbay•com>
[-- Attachment #2: xt_time.patch --]
[-- Type: text/plain, Size: 435 bytes --]
diff --git a/net/netfilter/xt_time.c b/net/netfilter/xt_time.c
index ff44f86..f9c55dc 100644
--- a/net/netfilter/xt_time.c
+++ b/net/netfilter/xt_time.c
@@ -170,7 +170,7 @@ static bool xt_time_match(const struct sk_buff *skb,
if (skb->tstamp.tv64 == 0)
__net_timestamp((struct sk_buff *)skb);
- stamp = skb->tstamp.tv64;
+ stamp = ktime_to_ns(skb->tstamp);
do_div(stamp, NSEC_PER_SEC);
if (info->flags & XT_TIME_LOCAL_TZ)
next reply other threads:[~2007-11-13 11:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-13 11:30 Eric Dumazet [this message]
2007-11-13 11:50 ` [NET] netfilter : xt_time should not assume CONFIG_KTIME_SCALAR David Miller
2007-11-13 12:07 ` Patrick McHardy
2007-11-13 12:48 ` Eric Dumazet
2007-11-13 15:38 ` Patrick McHardy
2007-11-13 13:41 ` [NET] random : secure_tcp_sequence_number " Eric Dumazet
2007-11-14 5:13 ` David Miller
2007-11-14 19:49 ` [stable] " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47398ADD.2030509@cosmosbay.com \
--to=dada1@cosmosbay$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=kaber@trash$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox