Subject: Re: [PATCH 2/5] accounting unit and variable

From: Hideo AOKI <[email-masked]>
Date: Tue, 13 Nov 2007 22:27:13 -0500

Hello,

Herbert Xu wrote:
> On Mon, Oct 29, 2007 at 05:23:10PM -0400, Hideo AOKI wrote:
>>  
>> +#define SK_DATAGRAM_MEM_QUANTUM ((int)PAGE_SIZE)
>> +
>> +static inline int sk_datagram_pages(int amt)
>> +{
>> +	return DIV_ROUND_UP(amt, SK_DATAGRAM_MEM_QUANTUM);
>> +}
> 
> Does this really have to be int? Unsigned would let the compiler
> optimise this to a simple shift.

Thank you for the comment.

This inline function is used to calculate the first argument of atomic_add()
and atomic_sub(). Since the argument is int, I believe that using int is
better than using unsigned int.

Best regards,
Hideo

--
Hitachi Computer Products (America) Inc.