Subject: Re: [PATCH 05/25] NFS: eliminate NIPQUAD(clp->cl_addr.sin_addr)

From: Chuck Lever <[email-masked]>
Date: Wed, 14 Nov 2007 11:52:49 -0500

YOSHIFUJI Hideaki / 吉藤英明 wrote:
> In article <[email-masked]> (at Tue, 13 Nov 2007 13:31:27 -0500), Chuck Lever <[email-masked]> says:
> 
>>  		   clp->rpc_ops->version,
>> -		   NIPQUAD(clp->cl_addr.sin_addr),
>> -		   ntohs(clp->cl_addr.sin_port),
>> +		   rpc_peeraddr2str(clp->cl_rpcclient, RPC_DISPLAY_HEX_ADDR),
>> +		   rpc_peeraddr2str(clp->cl_rpcclient, RPC_DISPLAY_HEX_PORT),
>>  		   atomic_read(&clp->cl_count),
> 
> Is this really safe?

What's unsafe about it?  rpc_peeraddr2str() is designed to be called 
this way.