Subject: Re: Null pointer dereference in nf_nat_move_storage(), kernel 2.6.23.1

From: Patrick McHardy <[email-masked]>
Date: Fri, 16 Nov 2007 01:00:22 +0100

David Miller wrote:
> From: Evgeniy Polyakov <[email-masked]>
> Date: Thu, 15 Nov 2007 15:06:59 +0300
>
>> Please test attached patch.
>>
>> This routing is called each time hash should be replaced, nf_conn has
>> extension list which contains pointers to connection tracking users
>> (like nat, which is right now the only such user), so when replace takes
>> place it should copy own extensions. Loop above checks for own
>> extension, but tries to move higer-layer one, which can lead to above
>> oops.
>>
>> Not tested, derived from code observation only.
>>
>> Signed-off-by: Evgeniy Polyakov <[email-masked]>
>
> It looks extremely correct to me.  Therefore I'm going to apply
> this and queue it up for -stable.
>
> Thanks Evgeniy, keep up the excellent work!
>
> Patrick, please let me know if you have any objections.

The patch looks fine, thanks. I was just waiting for confirmation
from Chuck.