Subject: Re: FW: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode

From: Patrick McHardy <[email-masked]>
Date: Fri, 16 Nov 2007 15:46:26 +0100

Herbert Xu wrote:
> BTW, how does the VLAN TX acceleration work at all? It's using
> skb->cb to carry the tags but then calls dev_queue_xmit.  Once
> you do that packet schedulers can scribble all over skb->cb.
> 
> Also vlan_skb_recv should be moved out-of-line.  It's absolutely
> humongous.  It'll generate tail-calls anyway so performance-wise
> it's useless.

I have a number of VLAN cleanups queued and intend to do these
two changes on top.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/