Subject: Re: [PATCH, take2] netfilter : struct xt_table_info diet

From: Patrick McHardy <[email-masked]>
Date: Tue, 20 Nov 2007 08:50:15 +0100

Herbert Xu wrote:
> Simon Horman <[email-masked]> wrote:
>   
>> @@ -269,9 +269,12 @@ struct xt_table_info
>>        unsigned int underflow[NF_INET_NUMHOOKS];
>>
>>        /* ipt_entry tables: one per CPU */
>> -       char *entries[NR_CPUS];
>> +       /* Note : this field MUST be the last one, see XT_TABLE_INFO_SZ */
>> +       char *entries[1];
>>     
>
> Just do
>
> 	char *entries[];
>
> Not only is it ISO C99, but the compiler will die if it's not at
> the end.
>
> Actually I haven't read the rest of the patch, so scratch this
> comment if you really need to have one entry there for some reason :)
>   

I thought this too, but its needed for the bootstrap tables, which are
declared on the stack :)