Subject: Re: [PATCH net-2.6.25] qdisc: new rate limiter

From: Ben Greear <[email-masked]>
Date: Sat, 08 Dec 2007 13:59:11 -0800

Patrick McHardy wrote:
> Patrick McHardy wrote:
>> Stephen Hemminger wrote:
>>>
>>> +struct tc_rlim_qopt
>>> +{
>>> +    __u32   limit;        /* fifo limit (packets) */
>>> +    __u32    rate;        /* bits per sec */
>>>   
>>
>> This seems a bit small, 512mbit is the maximum rate.
>
> Its 4gbit of course, so I guess its enough :)
Even 4Gbps is well within the means of today's commodity 
hardware...seems easier to bump
to 64 bits now rather than have to make some backwards-compat hack a 
year from now...

Ben

-- 
Ben Greear <[email-masked]> 
Candela Technologies Inc  http://www.candelatech.com