Subject: dn_neigh_table vs pneigh_lookup/pneigh_delete

From: Pavel Emelyanov <[email-masked]>
Date: Wed, 19 Dec 2007 17:11:34 +0300

Hi

The pneigh_lookup/delete silently concerns, that the 
key_len of the table is more that 4 bytes. Look:

         u32 hash_val = *(u32 *)(pkey + key_len - 4);

The hash_val for the proxy neighbor entry is four last bytes
from the pkey.

But the dn_neigh_tables' key_len is sizeof(__le16), that is 2,
so setting (via netlink) the proxy neighbor entry for decnet 
will cause this entry to reside in arbitrary hash chain.

Is this too bad for decnet?

Thanks,
Pavel