From: Hideo AOKI <haoki@redhat•com>
To: David Miller <davem@davemloft•net>
Cc: herbert@gondor•apana.org.au, vladislav.yasevich@hp•com,
netdev@vger•kernel.org, lksctp-developers@lists•sourceforge.net,
tyasui@redhat•com, mhiramat@redhat•com,
satoshi.oshima.fk@hitachi•com, billfink@mindspring•com,
andi@firstfloor•org, johnpol@2ka•mipt.ru,
shemminger@linux-foundation•org, yoshfuji@linux-ipv6•org,
yumiko.sugita.yf@hitachi•com, haoki@redhat•com
Subject: Re: [PATCH 2/4] [CORE]: adding memory accounting points
Date: Mon, 31 Dec 2007 13:52:40 -0500 [thread overview]
Message-ID: <47793A78.3050100@redhat.com> (raw)
In-Reply-To: <20071230.235806.171376126.davem@davemloft.net>
David Miller wrote:
> This patch would not apply, because is contained changes
> present in the first patch, specifically:
<snip>
> And now I see exactly what you did, and it is quite careless.
>
> You wrote one big patch then tried to split it up by hand. This
> proves to me that you did not test the patches individually. Even
> worse, you did not even try to apply each patch nor compile the tree
> each step along the way as a basic sanity check.
Hello David,
You are right. Since I felt the patch was big, I divided
into three for review. And I mistook during the dividing.
> This wastes a lot of my time, as well as the time of other developers
> who might want to try out and test your changes.
I apologize for wasting your time.
> I will fix it up this time, but please do not ever do this again.
I really appreciate the fix. And I understood this.
Best regards,
Hideo
--
Hitachi Computer Products (America) Inc.
next prev parent reply other threads:[~2007-12-31 18:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-30 8:47 [PATCH 0/4] New interface for memory accounting (take 1) Hideo AOKI
2007-12-30 8:51 ` [PATCH 1/4] [CORE]: introducing new memory accounting interface Hideo AOKI
2007-12-30 8:51 ` [PATCH 2/4] [CORE]: adding memory accounting points Hideo AOKI
2007-12-31 7:58 ` David Miller
2007-12-31 18:52 ` Hideo AOKI [this message]
2007-12-30 8:53 ` [PATCH 3/4] [TCP]: using new interface Hideo AOKI
2007-12-30 8:54 ` [PATCH 4/4] [SCTP]: " Hideo AOKI
2007-12-31 7:34 ` [PATCH 0/4] New interface for memory accounting (take 1) David Miller
2007-12-31 15:17 ` Eric Dumazet
2007-12-31 19:03 ` Hideo AOKI
2007-12-31 23:01 ` David Miller
2007-12-31 18:46 ` Hideo AOKI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47793A78.3050100@redhat.com \
--to=haoki@redhat$(echo .)com \
--cc=andi@firstfloor$(echo .)org \
--cc=billfink@mindspring$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=johnpol@2ka$(echo .)mipt.ru \
--cc=lksctp-developers@lists$(echo .)sourceforge.net \
--cc=mhiramat@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=satoshi.oshima.fk@hitachi$(echo .)com \
--cc=shemminger@linux-foundation$(echo .)org \
--cc=tyasui@redhat$(echo .)com \
--cc=vladislav.yasevich@hp$(echo .)com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
--cc=yumiko.sugita.yf@hitachi$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox