Subject: Re: [PATCH net-2.6.25 6/6][NETFILTER] Use the ctl paths instead of hand-made analogue

From: Patrick McHardy <[email-masked]>
Date: Tue, 08 Jan 2008 17:13:30 +0100

Pavel Emelyanov wrote:
> The conntracks subsystem has a similar infrastructure
> to maintain ctl_paths, but since we already have it
> on the generic level, I think it's OK to switch to
> using it.
> 
> So, basically, this patch just replaces the ctl_table-s
> with ctl_path-s, nf_register_sysctl_table with 
> register_sysctl_paths() and removes no longer needed code.

Also looks good, thanks. But please remeber to CC netfilter-devel
on patches affecting netfilter.

> After this the net/netfilter/nf_sysctl.c file contains 
> the paths only.

That sounds like they should be moved to net/netfilter/core.c
instead and the file removed. I can take care of that once
your patches are in Dave's tree.