Subject: Re: [PATCH 2.6.25 1/1]S2io: Multiqueue network device support implementation

From: Jeff Garzik <[email-masked]>
Date: Tue, 22 Jan 2008 19:55:11 -0500

Sreenivasa Honnur wrote:
> Multiqueue netwrok device support implementation.
> - Added a loadable parameter "multiq" to enable/disable multiqueue support,
>   by default it is disabled.
> - skb->queue_mapping is not used for queue/fifo selection. FIFO iselection is
>   based on IP-TOS value, 0x0-0xF TOS values are mapped to 8 FIFOs.
> - Added per FIFO flags FIFO_QUEUE_START and FIFO_QUEUE_STOP. Check this flag
>   for starting and stopping netif queue and update the flags accordingly.
> - In tx_intr_handler added a check to ensure that we have free TXDs before wak-
>   ing up the queue.
> - Added helper functions for queue manipulation(start/stop/wakeup) to invoke
>   appropriate netif_ functions.
> - Calling netif_start/stop for link up/down case respectively.
> 
> Signed-off-by: Surjit Reang <[email-masked]>
> Signed-off-by: Sreenivasa Honnur <[email-masked]>

thanks, at a quick glance, the use of the new multi-queue APIs look ok. 
  I'll give it another in-depth look and merge it.