Subject: Re: [PATCH 1/5] netns netfilter: per-netns ip6tables

From: Patrick McHardy <[email-masked]>
Date: Thu, 24 Jan 2008 18:33:37 +0100

Alexey Dobriyan wrote:
> * Propagate netns from userspace down to xt_find_table_lock()
> * Register ip6 tables in netns (modules still use init_net)
> 
> Signed-off-by: Alexey Dobriyan <[email-masked]>
> ---
> 
>  include/linux/netfilter_ipv6/ip6_tables.h |    3 +
>  net/ipv6/netfilter/ip6_tables.c           |   50 +++++++++++++++---------------
>  net/ipv6/netfilter/ip6table_filter.c      |    2 -
>  net/ipv6/netfilter/ip6table_mangle.c      |    2 -
>  net/ipv6/netfilter/ip6table_raw.c         |    2 -
>  5 files changed, 31 insertions(+), 28 deletions(-)

This adds checkpatch warnings:

WARNING: line over 80 characters
#96: FILE: net/ipv6/netfilter/ip6_tables.c:1361:
+do_add_counters(struct net *net, void __user *user, unsigned int len, 
int compat)

WARNING: line over 80 characters
#229: FILE: net/ipv6/netfilter/ip6table_filter.c:135:
+       packet_filter = ip6t_register_table(&init_net, &__packet_filter, 
&initial_table.repl);

WARNING: line over 80 characters
#242: FILE: net/ipv6/netfilter/ip6table_mangle.c:167:
+       packet_mangler = ip6t_register_table(&init_net, 
&__packet_mangler, &initial_table.repl);

WARNING: line over 80 characters
#255: FILE: net/ipv6/netfilter/ip6table_raw.c:80:
+       packet_raw = ip6t_register_table(&init_net, &__packet_raw, 
&initial_table.repl);

ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 4 warnings, 214 lines checked

I'll fix them up, lets hope that it doesn't cause clashes
with the following patches.