Subject: Re: [PATCH net-2.6.25] [MACVLAN] Setting macvlan_handle_frame_hook to NULL when rtnl_link_register() fails.

From: Patrick McHardy <[email-masked]>
Date: Tue, 29 Jan 2008 16:19:04 +0100

Rami Rosen wrote:
> Hi,
>   In drivers/net/macvlan.c, when rtnl_link_register() fails
> in macvlan_init_module(), there is no point to set it (second time in this
> method) to macvlan_handle_frame; macvlan_init_module() will return a negative
> number, so instead this patch sets macvlan_handle_frame_hook to NULL.

Indeed, that seems to be a stupid cut-and-paste error. Thanks for
catching this.

Dave, please apply.