Subject: Re: [PATCH 01/24 for-2.6.25] DM9000: Fix endian-ness of data accesses. Patch from: Laurent Pinchart <[email-masked]>

From: Jeff Garzik <[email-masked]>
Date: Thu, 07 Feb 2008 09:54:12 -0500

Laurent Pinchart wrote:
> On Wednesday 06 February 2008 12:46, Jeff Garzik wrote:
>> two comments:
>>
>> 1) you should be using __le16 type
>>
>> 2) seems like you should do the same for RxStatus, rather than splitting it
> 
> The DM9000 datasheet (or rather the application notes) describes two distinct 
> fields, even though they both contain some kind of status information.

Sure, there are plenty of distinct fields, just like with every chipset. 
  That doesn't mean byte instructions are the best choice.

	Jeff