From: Daniel Lezcano <dlezcano@fr•ibm.com>
To: David Stevens <dlstevens@us•ibm.com>
Cc: "David Miller" <davem@davemloft•net>,
"Linux Netdev List" <netdev@vger•kernel.org>,
netdev-owner@vger•kernel.org,
"YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6•org>
Subject: Re: ipv6_chk_acast_addr remove unused loop
Date: Fri, 08 Feb 2008 18:48:04 +0100 [thread overview]
Message-ID: <47AC95D4.4090506@fr.ibm.com> (raw)
In-Reply-To: <OF1B77A186.F07F897A-ON882573E9.0060B0C5-882573E9.00614E3C@us.ibm.com>
David Stevens wrote:
> NACK.
>
> Daniel,
> This code is part of the in-kernel API for anycast, which is
> intended
> to be the same as for multicast. By removing support for NULL there,
> you're
> making a special case for the anycast code that isn't there in the
> multicast
> code (can't support a NULL dev), and you really aren't buying all that
> much for it.
I was hesitating to send this patch exactly for the reason you are
explaining. Apparently I did the bad choice :)
Thanks.
-- Daniel
prev parent reply other threads:[~2008-02-08 17:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-08 17:23 ipv6_chk_acast_addr remove unused loop Daniel Lezcano
2008-02-08 17:42 ` David Stevens
2008-02-08 17:48 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47AC95D4.4090506@fr.ibm.com \
--to=dlezcano@fr$(echo .)ibm.com \
--cc=davem@davemloft$(echo .)net \
--cc=dlstevens@us$(echo .)ibm.com \
--cc=netdev-owner@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox