Subject: Re: [PATCH] net/8021q/vlan_dev.c - Use print_mac

From: Patrick McHardy <[email-masked]>
Date: Mon, 18 Feb 2008 16:19:40 +0100

Joe Perches wrote:
> On Fri, 2008-02-15 at 02:58 -0800, David Miller wrote:
>> From: Bruno Randolf <[email-masked]>
>> Date: Fri, 15 Feb 2008 19:48:05 +0900
>>> is there any chance to include a macro like this for printing mac
>> addresses?
>>> its advantage is that it can be used without the need to declare
>> buffers for
>>> print_mac(), for example:
>> We specifically removed this sort of thing, please don't
>> add it back.

Why?

> @@ -404,11 +405,8 @@ static int vlan_dev_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
>  
>  	pr_debug("%s: about to send skb: %p to dev: %s\n",
>  		__FUNCTION__, skb, skb->dev->name);
> -	pr_debug("  " MAC_FMT " " MAC_FMT " %4hx %4hx %4hx\n",
> -		 veth->h_dest[0], veth->h_dest[1], veth->h_dest[2],
> -		 veth->h_dest[3], veth->h_dest[4], veth->h_dest[5],
> -		 veth->h_source[0], veth->h_source[1], veth->h_source[2],
> -		 veth->h_source[3], veth->h_source[4], veth->h_source[5],
> +	pr_debug("  %s %s %4hx %4hx %4hx\n",
> +		 print_mac(mac, veth->h_dest), print_mac(mac2, veth->h_source),

This results in print_mac getting called twice per packet even without
debugging. Whats the problem with MAC_FMT?