public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Pavel Emelyanov <xemul@openvz•org>
To: David Miller <davem@davemloft•net>,
	Vlad Yasevich <vladislav.yasevich@hp•com>
Cc: Linux Netdev List <netdev@vger•kernel.org>,
	lksctp-developers@lists•sourceforge.net
Subject: [PATCH][SCTP]: Pick up an orphaned sctp_sockets_allocated counter.
Date: Tue, 19 Feb 2008 19:36:58 +0300	[thread overview]
Message-ID: <47BB05AA.6090101@openvz.org> (raw)

This counter is currently write-only.

Drawing an analogy with the similar tcp counter, I think
that this one should be pointed by the sockets_allocated
members of sctp_prot and sctpv6_prot.

Or should it be instead removed at all?

Signed-off-by: Pavel Emelyanov <xemul@openvz•org>

---

diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index d47d578..44797ad 100644
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -6488,6 +6488,7 @@ struct proto sctp_prot = {
 	.memory_pressure = &sctp_memory_pressure,
 	.enter_memory_pressure = sctp_enter_memory_pressure,
 	.memory_allocated = &sctp_memory_allocated,
+	.sockets_allocated = &sctp_sockets_allocated,
 	REF_PROTO_INUSE(sctp)
 };
 
@@ -6521,6 +6522,7 @@ struct proto sctpv6_prot = {
 	.memory_pressure = &sctp_memory_pressure,
 	.enter_memory_pressure = sctp_enter_memory_pressure,
 	.memory_allocated = &sctp_memory_allocated,
+	.sockets_allocated = &sctp_sockets_allocated,
 	REF_PROTO_INUSE(sctpv6)
 };
 #endif /* defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE) */

             reply	other threads:[~2008-02-19 16:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-19 16:36 Pavel Emelyanov [this message]
2008-02-19 16:43 ` [Lksctp-developers] [PATCH][SCTP]: Pick up an orphaned sctp_sockets_allocated counter Vlad Yasevich
2008-02-20  8:23   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47BB05AA.6090101@openvz.org \
    --to=xemul@openvz$(echo .)org \
    --cc=davem@davemloft$(echo .)net \
    --cc=lksctp-developers@lists$(echo .)sourceforge.net \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=vladislav.yasevich@hp$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox