Subject: Re: [PATCH 2/4] [RFC] e1000: make ioport free for supported devices

From: Jeff Garzik <[email-masked]>
Date: Wed, 05 Mar 2008 06:32:11 -0500

Auke Kok wrote:
> From: Tomohiro Kusumi <[email-masked]>
> 
> Most e1000 devices do not need ioport access to function properly.
> This is desirable for a few massive homed systems where ioport
> resources become constrained.
> 
> This patch is based on the code from Tomohiro Kusumi, heavily
> modified to fit PCI API changes and e1000 driver changes.
> 
> Signed-off-by: Tomohiro Kusumi <[email-masked]>
> Signed-off-by: Auke Kok <[email-masked]>

I don't think you need pci_select_bars()?  It should just be 
pci_enable_device_mem() in both paths AFAICS...