Subject: Re: [patch 0/9][NETNS][IPV6] make addrconf and icmp per namespace

From: Daniel Lezcano <[email-masked]>
Date: Wed, 05 Mar 2008 20:55:08 +0100

David Miller wrote:
> From: Daniel Lezcano <[email-masked]>
> Date: Wed, 05 Mar 2008 18:56:49 +0100
> 
>> The following patchset makes the different part of ipv6 to take
>> into account the namespaces. On top of that, addrconf and icmp
>> are now aware how to use the namespaces too. So we can move an
>> interface inside the namespace and set ip up to have an ipv6
>> address autoconfigured and be able to ping it.
>>
>> ndisc will come very soon ... :)
> 
> Applied and pushed out to net-2.6.26, thanks.
> 
> Can you quickly resolve this turd which got added by
> these changes to net/ipv6/addrconf.c?
> 
> static void addrconf_net_exit(struct net *net)
> {
> 	struct net_device *dev;
> 
> 	/*
> 	 * Remove loopback references from default routing entries
> 	 */
> /* 	in6_dev_put(net->ipv6.ip6_null_entry->rt6i_idev); */
> /* #ifdef CONFIG_IPV6_MULTIPLE_TABLES */
> /* 	in6_dev_put(net->ipv6.ip6_prohibit_entry->rt6i_idev); */
> /* 	in6_dev_put(net->ipv6.ip6_blk_hole_entry->rt6i_idev); */
> /* #endif */
> 
> Either turn the code on or remove it.
> 
> The upstream tree isn't a place to take "notes" using commented out
> code to remind you later about something.

Oops, sorry. I forgot to remove this comment. I will remove it asap.