Subject: Re: [patch 16/17] drivers/net/8390.c: replace init_module&cleanup_module with module_init&module_exit

From: "Kok, Auke" <[email-masked]>
Date: Thu, 20 Mar 2008 11:15:19 -0700

Andrew Morton wrote:
> On Fri, 07 Mar 2008 16:00:10 -0800
> "Kok, Auke" <[email-masked]> wrote:
> 
>> [email-masked] wrote:
>>> From: Jon Schindler <[email-masked]>
>>>
>>> Replace init_module and cleanup_module with static functions and
>>> module_init/module_exit.
>>>
>>> Signed-off-by: Jon Schindler <[email-masked]>
>>> Cc: Alan Cox <[email-masked]>
>>> Signed-off-by: Andrew Morton <[email-masked]>
>> something went wrong here as this patch already appears to be in jeff's upstream
>> tree as commit 8724c2de65fe527f5b7aa662fcb8573fb8cd02f2, but breaks compile.
>>
>> with CONFIG_NE2K_PCI=m:
>>
>>   CC [M]  drivers/net/8390.o
>> drivers/net/8390.c: In function '__inittest':
>> drivers/net/8390.c:60: error: 'ns8390_init_module' undeclared (first use in this
>> function)
>> drivers/net/8390.c:60: error: (Each undeclared identifier is reported only once
>> drivers/net/8390.c:60: error: for each function it appears in.)
>> make[2]: *** [drivers/net/8390.o] Error 1
>> make[1]: *** [drivers/net] Error 2
>> make: *** [drivers] Error 2
>>
>>
>> reverting the patch fixes the issue, but better would be to fix.
>>
>> Signed-off-by: Auke Kok <[email-masked]>
>> Cc: Jon Schindler <[email-masked]>
>> Cc: Alan Cox <[email-masked]>
>> Cc: Andrew Morton <[email-masked]>
>>
>> ---
>> diff --git a/drivers/net/8390.c b/drivers/net/8390.c
>> index 0ed41a3..a499e86 100644
>> --- a/drivers/net/8390.c
>> +++ b/drivers/net/8390.c
>> @@ -57,7 +57,7 @@ static void __exit ns8390_module_exit(void)
>>  {
>>  }
>>
>> -module_init(ns8390_init_module);
>> +module_init(ns8390_module_init);
>>  module_exit(ns8390_module_exit);
>>  #endif /* MODULE */
>>  MODULE_LICENSE("GPL");
> 
> OK, thanks, I'll drop it.

Jeff,

this bug is now sitting in your upstream tree breaking my compiles :(

Please either apply my patch above or do what Andrew did.

thanks,

Auke