Subject: Re: [E1000-devel] [PATCH] e1000e: test MSI interrupts

From: "Kok, Auke" <[email-masked]>
Date: Wed, 26 Mar 2008 13:42:50 -0700

Jeff Garzik wrote:
> Auke Kok wrote:
>> From: Jesse Brandeburg <[email-masked]>
>>
>> Test the MSI interrupt physically once before assuming that it
>> actually works. Several platforms have already come across that
>> have non-functional MSI interrupts and this code will attempt
>> to detect those safely. Once the test succeeds MSI interrupts
>> will be enabled.
>>
>> Signed-off-by: Jesse Brandeburg <[email-masked]>
>> Signed-off-by: Auke Kok <[email-masked]>
>> ---
>>
>>  drivers/net/e1000e/defines.h |    1 
>>  drivers/net/e1000e/e1000.h   |    1 
>>  drivers/net/e1000e/netdev.c  |  161 ++++++++++++++++++++++++++++++++++++++++--
>>  3 files changed, 155 insertions(+), 8 deletions(-)
> 
> Ah, the perennial add-same-test-to-every-driver conundrum.
> 
> I think we are far enough along with MSI to _not_ do this anymore in 
> drivers.
> 
> The platforms with MSI problems should be discovered, made public, and 
> worked around.
> 
> Otherwise you hide the same problem, just for someone else to discover 
> with another component of the machine.

ok, that's reasonable as I have not recently seen any "new" reports against the
current trees.

We have to keep this patch in our out-of-tree version around though, since a lot
of distros still ship kernels without all the new MSI quirks. But that's not for
this forum.

Thanks,

Auke