Subject: Re: [patch for 2.6.25? 1/1] bonding: fix sysfs attribute handling

From: Jeff Garzik <[email-masked]>
Date: Thu, 27 Mar 2008 08:22:32 -0400

[email-masked] wrote:
> From: Libor Pechacek <[email-masked]>
> 
> For bonding interfaces any attempt to read the sysfs directory contents after
> module removal results in an oops.  The fix is to release sysfs attributes for
> the interfaces upon module unload.
> 
> Signed-off-by: Libor Pechacek <[email-masked]>
> Acked-by: Jay Vosburgh <[email-masked]>
> Cc: "David S. Miller" <[email-masked]>
> Cc: <[email-masked]>
> Signed-off-by: Andrew Morton <[email-masked]>
> ---
> 
>  drivers/net/bonding/bond_main.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff -puN drivers/net/bonding/bond_main.c~bonding-fix-sysfs-attribute-handling drivers/net/bonding/bond_main.c
> --- a/drivers/net/bonding/bond_main.c~bonding-fix-sysfs-attribute-handling
> +++ a/drivers/net/bonding/bond_main.c
> @@ -4528,8 +4528,7 @@ static void bond_free_all(void)
>  		netif_tx_unlock_bh(bond_dev);
>  		/* Release the bonded slaves */
>  		bond_release_all(bond_dev);
> -		bond_deinit(bond_dev);
> -		unregister_netdevice(bond_dev);
> +		bond_destroy(bond);

sent upstream already (davem has it in net-2.6, bound for upstream)