Subject: Re: kernel 2.6.25-rc7 highly unstable on high load

From: Eric Dumazet <[email-masked]>
Date: Fri, 28 Mar 2008 22:17:26 +0100

Denys Fedoryshchenko a écrit :
> It seems or patch change something (but it is just showing debug, strange), 
> or there is something fixed between 2.6.25-rc7-git1 and 2.6.25-rc7-git3. LC-
> trie working fine, HASH also i cannot see any leaks.

Yes, the fix is the patch we mentioned yesterday, and you told us you tried it :(

commit 7c0ecc4c4f8fd90988aab8a95297b9c0038b6160

[ICMP]: Dst entry leak in icmp_send host re-lookup code (v2).

Commit 8b7817f3a959ed99d7443afc12f78a7e1fcc2063 ([IPSEC]: Add ICMP host
relookup support) introduced some dst leaks on error paths: the rt
pointer can be forgotten to be put. Fix it bu going to a proper label.

Found after net namespace's lo refused to unregister :) Many thanks to
Den for valuable help during debugging.

Herbert pointed out, that xfrm_lookup() will put the rtable in case
of error itself, so the first goto fix is redundant.

Signed-off-by: Pavel Emelyanov <[email-masked]>
Signed-off-by: Denis V. Lunev <[email-masked]>
Signed-off-by: David S. Miller <[email-masked]>

> 
> I  will have to wait 5-6 hours to make sure. After this time pass, if i will 
> not see bug again, i will try to run kernel just with default debug like 
> before.
> 
> If it is required, i can test performance and cpu load with/without routing 
> cache on real workload. Sure it is better to have syntetic tests before that.