Subject: Re: [PATCH 6/8] e1000e: convert ndev_ printks to something smaller

From: Jeff Garzik <[email-masked]>
Date: Fri, 28 Mar 2008 22:03:59 -0400

Auke Kok wrote:
> From: Bruce Allan <[email-masked]>
> 
> The ndev_* printk's are too lenghty and we don't need to specify
> the adapter/netdev struct at all, making this a lot more readable.
> 
> Signed-off-by: Bruce Allan <[email-masked]>
> Signed-off-by: Auke Kok <[email-masked]>
> ---
> 
>  drivers/net/e1000e/e1000.h   |   27 ++++----
>  drivers/net/e1000e/ethtool.c |   38 +++++------
>  drivers/net/e1000e/netdev.c  |  148 +++++++++++++++++++-----------------------
>  drivers/net/e1000e/param.c   |   31 +++------
>  4 files changed, 108 insertions(+), 136 deletions(-)

This stuff should just be removed.

Either the code should be outputting "ethX: blahblah" via printk(), or 
the code should be outputting the standard dev_printk() prefix [driver 
name, PCI device info].

Also, it is recommended to use the NETIF_MSG_xxx bits to permit 
fine-grained control over which messages are output, on a per-port basis 
(controlled via ethtool).  grep around for 'msg_enable'

	Jeff

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace