Subject: Re: [PATCH / RFC 0/2] spinlocks fixup in fec / m68knommu driver

From: Jeff Garzik <[email-masked]>
Date: Fri, 28 Mar 2008 22:19:38 -0400

Sebastian Siewior wrote:
> I got into this after turning on spinlock debugging.
> 
> Jeff: The dev->hard_start_xmit callback is always called from softirq
> context so it is save to use spin_lock_irq(), right?

Some drivers do that, and it's fine.  But be aware spin_lock_irqsave() 
may be required for edge cases like netconsole.