From: Bernard Pidoux <bpidoux@free•fr>
To: Jarek Poplawski <jarkao2@gmail•com>
Cc: Francois Romieu <romieu@fr•zoreil.com>,
Linux Netdev List <netdev@vger•kernel.org>,
Jarek Poplawski <jarkao2@o2•pl>
Subject: Re: [AX25] kernel panic
Date: Sun, 30 Mar 2008 19:38:51 +0200 [thread overview]
Message-ID: <47EFD02B.8080006@free.fr> (raw)
In-Reply-To: <20080330091636.GA2847@ami.dom.local>
[-- Attachment #1: Type: text/plain, Size: 2588 bytes --]
Jarek Poplawski wrote:
> On Sun, Mar 30, 2008 at 10:43:07AM +0200, Bernard Pidoux wrote:
>> Hi Jarek,
>
> Hi Bernard,
>> please find attached another collection of data from
>> /var/log/kernel/info.log that I bziped for it is rather large.
>
> Thanks again. It looks like ROSE sockets aren't released properly.
> Here is a try to fix this. Could you test it with all previous patches
> present?
>
> Regards,
> Jarek P.
>
> (patch #5)
> ---
>
> diff -Nurp 2.6.24.4-/net/rose/af_rose.c 2.6.24.4+/net/rose/af_rose.c
> --- 2.6.24.4-/net/rose/af_rose.c 2008-01-24 23:58:37.000000000 +0100
> +++ 2.6.24.4+/net/rose/af_rose.c 2008-03-30 10:53:19.000000000 +0200
> @@ -599,17 +599,24 @@ static int rose_release(struct socket *s
>
> if (sk == NULL) return 0;
>
> + sock_hold(sk);
> + sock_orphan(sk);
> + lock_sock(sk);
> rose = rose_sk(sk);
>
> switch (rose->state) {
> case ROSE_STATE_0:
> + release_sock(sk);
> rose_disconnect(sk, 0, -1, -1);
> + lock_sock(sk);
> rose_destroy_socket(sk);
> break;
>
> case ROSE_STATE_2:
> rose->neighbour->use--;
> + release_sock(sk);
> rose_disconnect(sk, 0, -1, -1);
> + lock_sock(sk);
> rose_destroy_socket(sk);
> break;
>
> @@ -634,6 +641,8 @@ static int rose_release(struct socket *s
> }
>
> sock->sk = NULL;
> + release_sock(sk);
> + sock_put(sk);
>
> return 0;
> }
> --
Jarek,
It looks like you hit the right target !
There is no more warnings and no more ax25_frames_acked or
sk_ax25_debug.
We only get ax25_create and ax25_release data, plus ax25_make_new when
there is an AX25 connexion.
cat /var/log/messages | grep 'Mar 30 17' | grep AX...
Mar 30 17:00:58 f6bvp-9 kernel: AX25+ ax25_create, 866, c73a6738, c3300040
Mar 30 17:00:58 f6bvp-9 kernel: AX25- ax25_release, 959, c73a6738, c3300040
Mar 30 17:00:58 f6bvp-9 kernel: AX25+ ax25_create, 866, c73a6738, c3300040
Mar 30 17:00:58 f6bvp-9 kernel: AX25- ax25_release, 959, c73a6738, c3300040
Mar 30 17:01:23 f6bvp-9 kernel: AX25; ax25_make_new, 943, c73a6738, c762a820
Mar 30 17:01:23 f6bvp-9 kernel: AX25= ax25_accept, 1386, c73a6738,
c762a820, c3300040
Mar 30 17:01:58 f6bvp-9 kernel: AX25+ ax25_create, 866, c73a6f68, c7673ac0
Mar 30 17:01:58 f6bvp-9 kernel: AX25- ax25_release, 959, c73a6f68, c7673ac0
Mar 30 17:01:58 f6bvp-9 kernel: AX25+ ax25_create, 866, c73a6f68, c7673ac0
Please excuse the following questions if you find they are too naive.
Could you tell us how did you suspect ROSE socket from the data
collected ? and why improperly released ROSE sockets could interfere
with AX25 ?
Regards,
Bernard P.
[-- Attachment #2: AX25.kernel.debug5.bz2 --]
[-- Type: application/x-bzip, Size: 869 bytes --]
next prev parent reply other threads:[~2008-03-30 17:38 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-18 10:44 [AX25] kernel panic Bernard Pidoux F6BVP
2008-03-18 21:25 ` Francois Romieu
2008-03-19 7:36 ` Bernard Pidoux F6BVP
2008-03-19 20:57 ` Bernard Pidoux
2008-03-20 7:30 ` Jarek Poplawski
2008-03-20 22:58 ` Bernard Pidoux
2008-03-21 0:28 ` Jarek Poplawski
2008-03-21 9:52 ` Bernard Pidoux
2008-03-21 11:22 ` Jarek Poplawski
2008-03-21 9:40 ` Bernard Pidoux
2008-03-22 11:36 ` Jarek Poplawski
2008-03-23 17:00 ` Bernard Pidoux
2008-03-24 20:51 ` Jarek Poplawski
2008-03-25 13:23 ` Bernard Pidoux
2008-03-25 20:51 ` Jarek Poplawski
2008-03-26 18:35 ` Jarek Poplawski
2008-03-28 8:24 ` Bernard Pidoux
2008-03-28 8:27 ` Bernard Pidoux
2008-03-28 12:07 ` Jarek Poplawski
2008-03-29 12:04 ` Bernard Pidoux
2008-03-29 12:24 ` Jarek Poplawski
2008-03-30 8:43 ` Bernard Pidoux
2008-03-30 9:16 ` Jarek Poplawski
2008-03-30 17:38 ` Bernard Pidoux [this message]
2008-03-30 18:49 ` Jarek Poplawski
2008-03-30 9:00 ` Bernard Pidoux
[not found] ` <47EE38BA.9090500@free.fr>
[not found] ` <20080329130451.GC3407@ami.dom.local>
[not found] ` <47EF6479.7030702@free.fr>
[not found] ` <20080330115958.GA4975@ami.dom.local>
2008-04-01 20:37 ` Bernard Pidoux
2008-04-02 6:41 ` [ROSE/AX25] af_rose: rose_release() fix Jarek Poplawski
2008-04-02 6:56 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2009-09-09 22:28 [AX25] kernel panic Bernard Pidoux
2009-09-11 19:21 ` Jarek Poplawski
2009-09-15 10:16 ` Bernard Pidoux
[not found] ` <20090910142436.GB10547@linux-mips.org>
[not found] ` <4AA9288B.2070205@upmc.fr>
[not found] ` <20090911120557.GA12175@linux-mips.org>
2009-09-20 8:42 ` Bernard Pidoux
2009-09-20 9:09 ` f8arr
2009-09-20 21:02 ` Jarek Poplawski
2009-09-21 8:44 ` Bernard Pidoux
2009-09-21 20:11 Jarek Poplawski
2009-09-23 21:17 ` Bernard Pidoux F6BVP
2009-09-24 8:07 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47EFD02B.8080006@free.fr \
--to=bpidoux@free$(echo .)fr \
--cc=jarkao2@gmail$(echo .)com \
--cc=jarkao2@o2$(echo .)pl \
--cc=netdev@vger$(echo .)kernel.org \
--cc=romieu@fr$(echo .)zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox