Subject: Re: [PATCH 1/5] fec: kill warnings

From: Greg Ungerer <[email-masked]>
Date: Thu, 03 Apr 2008 19:30:30 +1000

Sebastian Siewior wrote:
> * Greg Ungerer | 2008-04-03 16:30:48 [+1000]:
> 
>> Hi Sebastian,
>>
>> Sebastian Siewior wrote:
>>> linux-2.6-mk68/drivers/net/fec.c: In function 'fec_enet_module_init':
>>> linux-2.6-mk68/drivers/net/fec.c:2627: warning: unused variable 'j'
>>> linux-2.6-mk68/drivers/net/fec.c: At top level:
>>> linux-2.6-mk68/drivers/net/fec.c:2136: warning: 'mii_link_interrupt' 
>>> defined but not used
>>> Signed-off-by: Sebastian Siewior <[email-masked]>
>>> --- a/drivers/net/fec.c
>>> +++ b/drivers/net/fec.c
>>> @@ -67,6 +67,11 @@
>>>  #define	FEC_MAX_PORTS	1
>>>  #endif
>>>  +#if defined(CONFIG_M523x) || defined(CONFIG_M527x) || 
>>> defined(CONFIG_M528x) || \
>>> +	defined(CONFIG_M520x) || defined(CONFIG_M532x)
>>> +#define DONT_NEED_mii_link_interrupt
>> I think using normal positive logic would be clearer, eg:
>>
>>   HAVE_mii_link_interupt
> Will do it.
> 
>> Very few of the boards I have come across with the FEC silicon
>> actually hook up the MII interrupt, so the list of devices that
>> have it will be smaller.
> This doesn't mean we get rid of it, does it? :)

No, no. It nice for those that do it.

Regards
Greg

------------------------------------------------------------------------
Greg Ungerer  --  Chief Software Dude       EMAIL:     [email-masked]
SnapGear -- a Secure Computing Company      PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com