Subject: Re: Re-queueing of skb in vlan_skb_recv

From: Patrick McHardy <[email-masked]>
Date: Fri, 11 Apr 2008 14:46:35 +0200

Brian Oostenbrink wrote:
> In vlan_skb_recv, packets are generally stripped of their vlan header,
> and then re-queued via netif_rx().  Is there a reason for re-queuing
> these instead of calling netif_receive_skb() directly?  On our system
> (an embedded linux router), this re-queuing has a significant
> performance penalty.

Its done to save stack space. There's currently a discussion
about making loopback use netif_receive_skb in case enough
stack is still available. Once that patch gets merged I'll
change VLAN in a similar way.