Subject: Re: [PATCH 2/7] ATM cell alignment.

From: Patrick McHardy <[email-masked]>
Date: Sun, 13 Apr 2008 06:44:57 +0200

Jesper Dangaard Brouer wrote:
> On Fri, 11 Apr 2008, Patrick McHardy wrote:
> 
>> Jesper Dangaard Brouer wrote:
>>> @@ -87,6 +111,16 @@ int tc_calc_rtable(struct tc_ratespec *r, __u32
>>>  *rtab, int cell_log, unsigned mt
>>>           unsigned sz = ((i+1)<<cell_log);
>>>           if (sz < mpu)
>>>               sz = mpu;
>>>  +        switch (linklayer) {
>>>  +        case LINKLAYER_ATM:
>>>  +            sz = tc_align_to_atm(sz);
>>>  +            break;
>>>  +        case LINKLAYER_ETHERNET:
>>>  +            // No size adjustments on Ethernet
>>>  +            break;
>>
>> Couldn't this use the ARPHRD values?
> 
> It would make it more difficult to expand to new linklayer types.  For 
> example I cannot find a define suitable for DOCSIS (cabel modems) (Thats 
> next om my list to make DaveM happy ;-))

Fair enough, I guess ARPHRD is not the perfect match for this.