Subject: Re: [PATCH 3/5] e1000e: Allow TSO to trickle down to VLAN device

From: Patrick McHardy <[email-masked]>
Date: Mon, 14 Apr 2008 19:11:23 +0200

Auke Kok wrote:
> Fix TSO over VLAN's by propagating settings to our VLAN devices.
>   

> @@ -378,8 +381,21 @@ static int e1000_set_tso(struct net_device *netdev, u32 data)
>  	} else {
>  		netdev->features &= ~NETIF_F_TSO;
>  		netdev->features &= ~NETIF_F_TSO6;
> +		/* disable TSO on all VLANs if they're present */
> +		if (!adapter->vlgrp)
> +			goto tso_out;
> +		for (i = 0; i < VLAN_GROUP_ARRAY_LEN; i++) {
> +			v_netdev = vlan_group_get_device(adapter->vlgrp, i);
> +			if (!v_netdev)
> +				continue;
> +
> +			v_netdev->features &= ~NETIF_F_TSO;
> +			v_netdev->features &= ~NETIF_F_TSO6;
> +			vlan_group_set_device(adapter->vlgrp, i, v_netdev);
>   

What exactly is this supposed to fix? If this simply wants
to propagate feature changes, I think it should use
netdev_feat_change and handle that within the VLAN code.