Subject: Re: remove special ioctl from hso driver, replace by rfkill

From: Paulius Zaleckas <[email-masked]>
Date: Fri, 18 Apr 2008 00:42:07 +0300

Oliver Neukum wrote:
>  /* called once for each interface upon device insertion */
>  static int hso_probe(struct usb_interface *interface,
>  		     const struct usb_device_id *id)
>  {
>  	int mux, i, if_num, port_spec;
>  	unsigned char port_mask;
> +	char *rfkn;
>  	struct hso_device *hso_dev = NULL;
>  	struct hso_shared_int *shared_int = NULL;
>  	struct hso_device *tmp_dev = NULL;
> @@ -2747,6 +2706,27 @@ static int hso_probe(struct usb_interfac
>  		goto exit;
>  	}
>  
> +	hso_dev->rfkill = rfkill_allocate(&interface_to_usbdev(interface)->dev,
> +				RFKILL_TYPE_WLAN);

What will happen if rfkill is not enabled on kernel? I think HSO should
not depend on rfkill. Solution should be to do #ifdef CONFIG_RFKILL..?

> +	if (!hso_dev->rfkill)
> +		goto exit;
> +	rfkn = kzalloc(20, GFP_KERNEL);
> +	if (!rfkn) {
> +		rfkill_free(hso_dev->rfkill);
> +		goto exit;
> +	}
> +	snprintf(rfkn, 20, "hso-%d", if_num);
> +	hso_dev->rfkill->name = rfkn;
> +	hso_dev->rfkill->state = RFKILL_STATE_ON;
> +	hso_dev->rfkill->data = hso_dev;
> +	hso_dev->rfkill->toggle_radio = hso_radio_toggle;
> +	if (rfkill_register(hso_dev->rfkill) < 0) {
> +		kfree(rfkn);
> +		hso_dev->rfkill->name = NULL;
> +		rfkill_free(hso_dev->rfkill);
> +		goto exit;
> +	}
> +
>  	usb_driver_claim_interface(&hso_driver, interface, hso_dev);

Looks like it is possible to disable RF part of devices through sysfs...
Tomorrow I will upgrade to 2.6.25 and I will try to test it.

Paulius