Subject: Re: [PATCH 2.6.25 1/2]S2io: Fix memory leak during free_tx_buffers

From: Jeff Garzik <[email-masked]>
Date: Fri, 25 Apr 2008 01:48:08 -0400

Sreenivasa Honnur wrote:
> - Fix the memory leak during free_tx_buffers.
>  
> Signed-off-by: Santosh Rastapur <[email-masked]>
> Signed-off-by: Ramkrishna Vepa <[email-masked]>
> ---
> diff -Nurp 2.0.26.20/drivers/net/s2io.c 2.0.26.22-1/drivers/net/s2io.c
> --- 2.0.26.20/drivers/net/s2io.c	2008-04-22 15:02:38.000000000 -0700
> +++ 2.0.26.22-1/drivers/net/s2io.c	2008-04-22 15:12:25.000000000 -0700
> @@ -2339,7 +2339,7 @@ static void free_tx_buffers(struct s2io_
>  	for (i = 0; i < config->tx_fifo_num; i++) {
>  		unsigned long flags;
>  		spin_lock_irqsave(&mac_control->fifos[i].tx_lock, flags);
> -		for (j = 0; j < config->tx_cfg[i].fifo_len - 1; j++) {
> +		for (j = 0; j < config->tx_cfg[i].fifo_len; j++) {
>  			txdp = (struct TxD *) \
>  			mac_control->fifos[i].list_info[j].list_virt_addr;

applied 1-2 to upstream

since 2.6.25 was released, we need to put in a separate request to 
[email-masked]