Subject: [PATCH 2/2][ATM]: Bad locking on br2684_devs modifications.

From: Pavel Emelyanov <[email-masked]>
Date: Sun, 04 May 2008 11:39:00 +0400

The list_del happens under read-locked devs_lock.

Signed-off-by: Pavel Emelyanov <[email-masked]>

---
 net/atm/br2684.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/atm/br2684.c b/net/atm/br2684.c
index 3a74ff8..13858e2 100644
--- a/net/atm/br2684.c
+++ b/net/atm/br2684.c
@@ -346,9 +346,9 @@ static void br2684_push(struct atm_vcc *atmvcc, struct sk_buff *skb)
 		/* skb==NULL means VCC is being destroyed */
 		br2684_close_vcc(brvcc);
 		if (list_empty(&brdev->brvccs)) {
-			read_lock(&devs_lock);
+			write_lock_irq(&devs_lock);
 			list_del(&brdev->br2684_devs);
-			read_unlock(&devs_lock);
+			write_unlock_irq(&devs_lock);
 			unregister_netdev(net_dev);
 		}
 		return;
-- 
1.5.3.4